Re: [Xen-devel] [PATCH] xen/arm: Panic if we are unable to initialize platform timer

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-11-15 at 15:58 +0000, Stefano Stabellini wrote:
> On Fri, 15 Nov 2013, Julien Grall wrote:
> > The caller of xen_init_time, start_xen, doesn't check the return value
> > of the function. Xen will silently ignore the error and continue.
> > 
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I did wonder if it might be worth pushing the panic down into
platform_time_init, so that the message could be more specific. But that
seems like it relies on platform code to be more aware of when to panic
and to use consistent wording etc. So all in all I think it is better
here.

> 
> 
> >  xen/arch/arm/time.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
> > index a30d422..938995d 100644
> > --- a/xen/arch/arm/time.c
> > +++ b/xen/arch/arm/time.c
> > @@ -132,7 +132,7 @@ int __init init_xen_time(void)
> >  
> >      res = platform_init_time();
> >      if ( res )
> > -        return res;
> > +        panic("Timer: Cannot initialize platform timer\n");
> >  
> >      /* Check that this CPU supports the Generic Timer interface */
> >      if ( !cpu_has_gentimer )
> > -- 
> > 1.8.3.1
> > 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel