Re: [Xen-devel] [PATCH v4 16/17] libxl: build a device tree for ARM guests

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 12 Nov 2013, Ian Campbell wrote:
> +static int make_intc_node(libxl__gc *gc, void *fdt,
> +                          unsigned long long gicd_base,
> +                          unsigned long long gicd_size,
> +                          unsigned long long gicc_base,
> +                          unsigned long long gicc_size)
> +{
> +    int res;
> +    const char *name = GCSPRINTF("interrupt-controller@%08llx", gicd_base);
> +
> +    res = fdt_begin_node(fdt, name);
> +    if (res) return res;
> +
> +    res = fdt_property_compat(gc, fdt, 2,
> +                              "arm,cortex-a15-gic",
> +                              "arm,cortex-a9-gic");
> +    if (res) return res;
> +
> +
> +    res = fdt_property_cell(fdt, "#interrupt-cells", 3);
> +    if (res) return res;
> +
> +    res = fdt_property_cell(fdt, "#address-cells", 0);
> +    if (res) return res;
> +
> +    res = fdt_property(fdt, "interrupt-controller", NULL, 0);
> +    if (res) return res;
> +
> +    res = fdt_property_regs(gc, fdt, ROOT_ADDRESS_CELLS, ROOT_SIZE_CELLS,
> +                            2,
> +                            (uint64_t)gicd_base, (uint64_t)gicd_size,
> +                            (uint64_t)gicc_base, (uint64_t)gicc_size);
> +    if (res) return res;
> +
> +    res = fdt_property_cell(fdt, "linux,phandle", PHANDLE_GIC);
> +    if (res) return res;
> +
> +    res = fdt_property_cell(fdt, "phandle", PHANDLE_GIC);
> +    if (res) return res;

Why are you adding this property?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel