Re: [Xen-devel] [PATCH V3] xl: HVM domain S3 bugfix

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-10-22 at 06:03 +0000, Liu, Jinsong wrote:
> Ian Campbell wrote:
> > On Mon, 2013-09-09 at 03:29 +0000, Liu, Jinsong wrote:
> >> From 18344216b432648605726b137b348f28ef64a4ef Mon Sep 17 00:00:00
> >> 2001 
> >> From: Liu Jinsong <jinsong.liu@xxxxxxxxx>
> >> Date: Fri, 23 Aug 2013 23:30:23 +0800
> >> Subject: [PATCH V3] xl: HVM domain S3 bugfix
> >> 
> >> Currently Xen hvm s3 has a bug coming from the difference between
> >> qemu-traditioanl and qemu-xen. For qemu-traditional, the way to
> > 
> > "traditional"
> > 
> >> resume from hvm s3 is via 'xl trigger' command. However, for
> >> qemu-xen, the way to resume from hvm s3 inherited from standard
> >> qemu, i.e. via QMP, and it doesn't work under Xen.
> >> 
> >> The root cause is, for qemu-xen, 'xl trigger' command didn't reset
> >> devices, while QMP didn't unpause hvm domain though they did qemu
> >> system reset.
> >> 
> >> We have two qemu patches one xl patch to fix the HVM S3 bug:
> >> This patch is the xl patch. It invokes QMP system_wakeup so that
> >> qemu logic for hvm s3 could be triggerred.
> > 
> > "triggered"
> > 
> >> 
> >> Signed-off-by: Liu Jinsong <jinsong.liu@xxxxxxxxx>
> > 
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > I'll hold off on applying until someone givers me a heads up that the
> > qemu side is in place. I'll try and remember to fix the commit message
> > typos as I commit, so no need to resend for those.
> > 
> 
> Ian,
> 
> The 2 qemu patches have been checked in qemu tree w/ commit number
> 4bc78a877252d772b983810a7d2c0be00e9be70e
> 11addd0ab9371af2b6ec028c7fe4e4c4992252fc
> 
> So would you please check this xl patch in Xen?

Done. I suppose these changes need to make their way into
QEMU_UPSTREAM_REVISION in xen.git/Config.mk, but I assume that'll happen
in due course.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel