Re: [Xen-devel] [PATCH] xen/arm: UART addresses are not always aligned to a page.

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 28 October 2013 18:28, Jon Fraser <jfraser@xxxxxxxxxxxx> wrote:
> Add the page offset of the UART to the mapped address.

For the next version can you add [PATCH Vn] in the subject? Where 'n'
is the version of the patch.

> Signed-off-by: Jon Fraser <jfraser@xxxxxxxxxxxx>
> ---
>  xen/arch/arm/arm32/debug.S      | 5 +++--
>  xen/arch/arm/arm32/head.S       | 2 +-
>  xen/arch/arm/arm64/debug.S      | 4 ++--
>  xen/arch/arm/arm64/head.S       | 2 +-
>  xen/include/asm-arm/asm_defns.h | 3 +++
>  5 files changed, 10 insertions(+), 6 deletions(-)

[...]

>          /* Map the DTB in the boot misc slot */
> diff --git a/xen/include/asm-arm/asm_defns.h b/xen/include/asm-arm/asm_defns.h
> index 36e72ff..5bcaa44 100644
> --- a/xen/include/asm-arm/asm_defns.h
> +++ b/xen/include/asm-arm/asm_defns.h
> @@ -7,6 +7,9 @@
>  #endif
>  #include <asm/processor.h>
>
> +/* Offset in page of UART base address */
> +#define UART_OFFSET (EARLY_UART_BASE_ADDRESS & ~PAGE_MASK)
> +

Actually I would move this define in asm/early-printk.h. It's the best place.
Can you also rename the name to EARLY_UART_OFFSET?

In order to avoid numerous FIXMAP(CONSOLE) + UART_OFFSET, is it
possible to create a define EARLY_UART_VIRTUAL_ADDRESS and use it
everywhere?

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel