Re: [Xen-devel] [PATCH 6/7] xen: adds vNUMA info debug-key u

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.10.13 at 00:40, Elena Ufimtseva <ufimtseva@xxxxxxxxx> wrote:
> @@ -389,6 +389,24 @@ static void dump_numa(unsigned char key)
>  
>               for_each_online_node(i)
>                       printk("    Node %u: %u\n", i, page_num_node[i]);
> +
> +                if (d->vnuma.nr_vnodes > 0) 

The file/function so far uses tab indentation, and hence so should
you.

> +                {
> +                    printk("    Domain has %d vnodes\n", d->vnuma.nr_vnodes);
> +                    for(j = 0; j < d->vnuma.nr_vnodes; j++) {

Coding style.

Also, what's the point of using a new variable "j" here when the
available "i" could be re-used?

> +                        printk("        vnode %d - pnode %d:", j,
> +                                        d->vnuma.vnode_to_pnode[j] > 
> MAX_NUMNODES ?

Didn't you mean >= ?

> +                                        -1 : d->vnuma.vnode_to_pnode[j]); 
> +                        printk(" %Lu MB, \n", (unsigned long long) 

%"PRIu64" and no cast please. And what's the space good for
immediately preceding the \n in the format string?

> +                                           (d->vnuma.vnuma_memblks[j].end -
> +                                           d->vnuma.vnuma_memblks[j].start) 
> +                                           >> 20);
> +                        }
> +                    printk("    Domain vcpu to vnode: ");
> +                    for(j = 0; j < d->max_vcpus; j++) 

Coding style again.

> +                        printk("%d ", d->vnuma.vcpu_to_vnode[j]);

So with a 64-vCPU guest I'm going to get an over 200 characters
long line? Please properly wrap such potentially long output.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel