[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH net-next] xen-netback: fix xenvif_count_skb_slots()
On Mon, 2013-10-07 at 15:36 -0400, David Miller wrote: > From: Paul Durrant <paul.durrant@xxxxxxxxxx> > Date: Fri, 4 Oct 2013 17:26:23 +0100 > > > Commit 4f0581d25827d5e864bcf07b05d73d0d12a20a5c introduced an error into > > xenvif_count_skb_slots() for skbs with a linear area spanning a page > > boundary. The alignment of skb->data needs to be taken into account, not > > just the head length. This patch fixes the issue by dry-running the code > > from xenvif_gop_skb() (and adjusting the comment above the function to note > > that). > > > > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx> > > There seems to be a lot of back and forth about what is the most > desirable way forward wrt. this commit and another similar one. > > Please advise. Lets revert 4f0581d25827d5e864bcf07b05d73d0d12a20a5c and see about making this stuff less fragile in the future. Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |