[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] Add scripts/get_maintainer.pl
On Thu, Oct 3, 2013 at 11:22 AM, Don Slutz <dslutz@xxxxxxxxxxx> wrote: > This is a minor change to QEMU's scripts/get_maintainer.pl to work in a XEN > souce tree. > > Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx> I've used a similarly-modified get_maintainers script (also from QEMU) lately and have found it useful (ie. with treewide Coverity fixes) and so would be happy to see this go in. A few suggestions though: This script was discussed in the recent past ( http://lists.xen.org/archives/html/xen-devel/2013-03/msg00984.html ) and IIUC the consensus was that, if it were to go in, the Git fallback searches would be disabled ($email_git_fallback = 0, AFAIK). IMO It's not necessary for a (relative to Linux) small project like Xen, with adequate MAINTAINERS coverage, to need this fallback. Also, speaking of adequate MAINTAINERS coverage, the last entry which attempts to have Keir as a fallback for "everything else" actually mean Keir is CC'd on everything using the script. This is because it uses all matching regexes and not just the most specific. Perhaps this entry needs to be commented out (leaving it their for manual inspection), or removed entirely? - Matthew _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |