Re: [Xen-devel] [PATCH 01/16] xen/events: refactor retrigger_dynirq() and resend_irq_on_evtchn()

[David Vrabel <dvrabel@xxxxxxxxxx>]

On 02/10/2013 22:08, Konrad Rzeszutek Wilk wrote:
> On Wed, Oct 02, 2013 at 10:01:13PM +0100, David Vrabel wrote:
>> On 02/10/2013 21:43, Konrad Rzeszutek Wilk wrote:
>>> On Wed, Oct 02, 2013 at 06:14:46PM +0100, David Vrabel wrote:
>>>> From: David Vrabel <david.vrabel@xxxxxxxxxx>
>>>>
>>>> These two function did the same thing with different parameters, put
>>>> the common bits in retrigger_evtchn().
>>>>
>>>> This changes the return value of resend_irq_on_evtchn() but the only
>>>> caller (in arch/ia64/xen/irq_xen.c) ignored the return value so this
>>>> is fine.
>>>>
>>>> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
>>>
>>> Hm, I thought I acked it?
>>
>> You said "Looks good to me" which wasn't official enough to add as a tag.
> 
> It is in the Linux kernel, see Documentation/SubmittingPatches:

I don't think it's sensible to interpret potentially ambiguous language
into a standard tag, regardless of what other Linux maintainers may do.
 This has gone wrong in the past.  If you want a tag added you should
write it out in full (which you still haven't done).

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel