Re: [Xen-devel] [PATCH 01/16] xen/events: refactor retrigger_dynirq() and resend_irq_on_evtchn()

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Oct 02, 2013 at 10:01:13PM +0100, David Vrabel wrote:
> On 02/10/2013 21:43, Konrad Rzeszutek Wilk wrote:
> > On Wed, Oct 02, 2013 at 06:14:46PM +0100, David Vrabel wrote:
> >> From: David Vrabel <david.vrabel@xxxxxxxxxx>
> >>
> >> These two function did the same thing with different parameters, put
> >> the common bits in retrigger_evtchn().
> >>
> >> This changes the return value of resend_irq_on_evtchn() but the only
> >> caller (in arch/ia64/xen/irq_xen.c) ignored the return value so this
> >> is fine.
> >>
> >> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> > 
> > Hm, I thought I acked it?
> 
> You said "Looks good to me" which wasn't official enough to add as a tag.

It is in the Linux kernel, see Documentation/SubmittingPatches:

13) When to use Acked-by: and Cc:                                               
   
                                                                                
   
The Signed-off-by: tag indicates that the signer was involved in the            
   
development of the patch, or that he/she was in the patch's delivery path.      
   
                                                                                
   
If a person was not directly involved in the preparation or handling of a       
   
patch but wishes to signify and record their approval of it then they can       
   
arrange to have an Acked-by: line added to the patch's changelog.               
   
                                                                                
   
Acked-by: is often used by the maintainer of the affected code when that        
   
maintainer neither contributed to nor forwarded the patch.                      
   
                                                                                
   
Acked-by: is not as formal as Signed-off-by:.  It is a record that the acker    
   
has at least reviewed the patch and has indicated acceptance.  Hence patch      
   
mergers will sometimes manually convert an acker's "yep, looks good to me"      
   
into an Acked-by:. 


> 
> David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel