[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH net-next] xen-netfront: convert to GRO API and advertise this feature
On Sep 22, 2013, at 7:55 AM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: > On Sat, 2013-09-21 at 17:05 +0100, Wei Liu wrote: >> Anirban was seeing netfront received MTU size packets, which downgraded >> throughput. The following patch makes netfront use GRO API which >> improves throughput for that case. > >> - netdev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO; >> + netdev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO | >> + NETIF_F_GRO; > > > This part is not needed. Shouldn't the flag be set? In dev_gro_receive() we do check if this flag is set or not: if (!(skb->dev->features & NETIF_F_GRO) || netpoll_rx_on(skb)) goto normal; -Anirban _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |