Re: [Xen-devel] [PATCH] x86: mark BUG()s and assertion failures as terminal.

[Tim Deegan <tim@xxxxxxx>]

At 16:44 +0100 on 19 Sep (1379609065), Andrew Cooper wrote:
> On 19/09/2013 15:39, Tim Deegan wrote:
> > This helps avoid static analysis false-positives, and might lead to
> > better code density as the compiler knows it doesn't have to restore
> > spilled state &c.
> >
> > Signed-off-by: Tim Deegan <tim@xxxxxxx>
> >
> 
> Out of interest, I tried looking at some numbers for this.
> 
> Using gcc 4.7.2 (Debian Wheezy), .text decreased by 656 bytes and
> .init.text decreased by 71 bytes.  While those are expected, .rodata
> decreased by 1224 bytes.  I am at a loss to explain the decrease in
> .rodata, but did double check my compiling, and find the decrease still
> present.

.rodata contains the bug frames themselves -- it looks like 150
ASSERT()s are now unreachable. :)  I'm sure that includes a lot of
duplication from ASSERT()s in header files.

The remaining handful of bytes seem to be from GCC inlining one or two
things it hadn't before, which makes the embedded copy of the symbol
table a little smaller. 

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel