Re: [Xen-devel] [PATCH] x86: mark BUG()s and assertion failures as terminal.

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/09/2013 15:39, Tim Deegan wrote:
> This helps avoid static analysis false-positives, and might lead to
> better code density as the compiler knows it doesn't have to restore
> spilled state &c.
>
> Signed-off-by: Tim Deegan <tim@xxxxxxx>
>

Out of interest, I tried looking at some numbers for this.

Using gcc 4.7.2 (Debian Wheezy), .text decreased by 656 bytes and
.init.text decreased by 71 bytes.  While those are expected, .rodata
decreased by 1224 bytes.  I am at a loss to explain the decrease in
.rodata, but did double check my compiling, and find the decrease still
present.

Either way, it looks to be a useful improvement.

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel