Re: [Xen-devel] [PATCH 11/28] libxl: only put poller if already gotten in libxl_event_wait

[Matthew Daley <mattjd@xxxxxxxxx>]

On Thu, Sep 19, 2013 at 12:29 AM, Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
> On 18/09/2013 04:37, Matthew Daley wrote:
>> Coverity-ID: 1055292
>> Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx>
>> ---
>>  tools/libxl/libxl_event.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/libxl/libxl_event.c b/tools/libxl/libxl_event.c
>> index e42b371..fd2f280 100644
>> --- a/tools/libxl/libxl_event.c
>> +++ b/tools/libxl/libxl_event.c
>> @@ -1476,7 +1476,7 @@ int libxl_event_wait(libxl_ctx *ctx, libxl_event 
>> **event_r,
>>      }
>>
>>   out:
>> -    libxl__poller_put(ctx, poller);
>> +    if (poller) libxl__poller_put(ctx, poller);
>
> Coding style would require the code to look like this:
>
> if ( poller )
>     libxl__poller_put(ctx, poller);

Indeed. I was going off the check just after the call to libxl__poller
get (and possibly confusing the style with Mini-OS's), but I suppose
this is only for rc/error-type checks. I'll resend a fixed patch.

- Matthew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel