Re: [Xen-devel] [PATCH 11/28] libxl: only put poller if already gotten in libxl_event_wait

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 18/09/2013 04:37, Matthew Daley wrote:
> Coverity-ID: 1055292
> Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx>
> ---
>  tools/libxl/libxl_event.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_event.c b/tools/libxl/libxl_event.c
> index e42b371..fd2f280 100644
> --- a/tools/libxl/libxl_event.c
> +++ b/tools/libxl/libxl_event.c
> @@ -1476,7 +1476,7 @@ int libxl_event_wait(libxl_ctx *ctx, libxl_event 
> **event_r,
>      }
>  
>   out:
> -    libxl__poller_put(ctx, poller);
> +    if (poller) libxl__poller_put(ctx, poller);

Coding style would require the code to look like this:

if ( poller )
    libxl__poller_put(ctx, poller);

~Andrew

>  
>      CTX_UNLOCK;
>      EGC_FREE;


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel