[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xen/build: Remove hacked up version of figlet
>>> On 13.09.13 at 11:30, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote: > On Fri, 2013-09-13 at 10:14 +0100, Jan Beulich wrote: >> >>> On 12.09.13 at 17:51, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote: >> > This hacked up version of figlet contributes a supprisingly large > proportion >> > of the Coverity issues found under xen/ (and therefore attributed against >> > Xen) >> > >> > Figlet can be found in all distros, so make use of it. >> >> None of the systems I checked (SLE10 and SLE11) have this >> installed, and I also don't know what package to look for. > > rpm.pbone.net shows a figlet package in OpenSUSE but not SLE, although I > don't know if it indexes them. Of course I searched the package set for something containing "figlet" in some way, so no, it's not there, also not on the SDK. >> Which >> you can read as an almost definitive NAK from me. I also can't >> see why you can't just exclude xen/tools/ from the Coverity >> scan... > > Or make the banner conditional on figlet's presence. Yes, perhaps. Albeit the banner is quite useful as an easily recognizable separator in multi-session logs or other lumped together stuff. I'd be more agreeable to this if the whole change wasn't just to make a tool happy... Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |