Re: [Xen-devel] [PATCH] xen/build: Remove hacked up version of figlet

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-09-13 at 10:14 +0100, Jan Beulich wrote:
> >>> On 12.09.13 at 17:51, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> > This hacked up version of figlet contributes a supprisingly large proportion
> > of the Coverity issues found under xen/ (and therefore attributed against 
> > Xen)
> > 
> > Figlet can be found in all distros, so make use of it.
> 
> None of the systems I checked (SLE10 and SLE11) have this
> installed, and I also don't know what package to look for.

rpm.pbone.net shows a figlet package in OpenSUSE but not SLE, although I
don't know if it indexes them.

It's the sort of trivial package I can imagine not being in an
enterprise distro.

>  Which
> you can read as an almost definitive NAK from me. I also can't
> see why you can't just exclude xen/tools/ from the Coverity
> scan...

Or make the banner conditional on figlet's presence.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel