Re: [Xen-devel] [PATCH v2 0/6] some libxc cleanups and xen-mfndump

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

[Amending the Cc-list, since I seem to have managed in including people
 that shouldn't be bothered by changes like these (Jan, Keir, sorry), as
 well as missing someone that should instead have been there in the
 first place (IanJ sorry)]

On mar, 2013-09-10 at 19:53 +0200, Dario Faggioli wrote:
> Hi everyone,
> 
> This is take 2 of an old submission of mine, doing some basic libxc cleanups
> and introducing a debugging tool I called xen-mfndump.
> 
> Basically, there are a few places in libxc where we issue do_domctl()-s
> directly, instead of using the proper xc_xxx() wrapper. This make the code
> bigger, redundant, more difficult to understand (e.g., "why xc_xxx() is called
> here and is not called there?"), less consistent and less grep-able. The first
> 4 patches of this series address this.
> 
> The last one introduce a little tool I'm using for debugging. It allows one to
> see the M2P of the host, the P2M of a domain, some info about the PTEs, and
> perform basic searches and comparisons on them. I'm finding it very useful 
> and,
> although I do not claim for my situation to be that common, I figured it could
> be nice to have it in the tree, so that is patch 6. Patch 5 is the small
> rework/additions necessary to make 6 possible.
> 
> Patches with an '*' next to their name below have been Reviewed-by Andrew
> Cooper.
> 
> Thanks and Regards,
> Dario
> 
> ---
> Dario Faggioli (6):
>       libxc: introduce xc_domain_get_guest_width()
>     * libxc: use xc_vcpu_setcontext() instead of calling do_domctl()
>       libxc: use xc_vcpu_getinfo() instead of calling do_domctl()
>     * libxc: allow for ctxt to be NULL in xc_vcpu_setcontext
>       libxc: introduce xc_map_domain_meminfo (and xc_unmap_domain_meminfo)
>       tools/misc: introduce xen-mfndump.
> 
> 
>  tools/libxc/xc_core.c           |   20 --
>  tools/libxc/xc_cpuid_x86.c      |    8 -
>  tools/libxc/xc_dom_boot.c       |   31 +--
>  tools/libxc/xc_dom_x86.c        |   13 -
>  tools/libxc/xc_domain.c         |  149 +++++++++++++-
>  tools/libxc/xc_domain_restore.c |   13 -
>  tools/libxc/xc_offline_page.c   |  192 +++---------------
>  tools/libxc/xc_pagetab.c        |    8 -
>  tools/libxc/xc_private.c        |    8 -
>  tools/libxc/xc_resume.c         |   21 --
>  tools/libxc/xenctrl.h           |   13 +
>  tools/libxc/xenguest.h          |   17 ++
>  tools/libxc/xg_private.h        |    9 +
>  tools/libxc/xg_save_restore.h   |    9 -
>  tools/misc/Makefile             |    7 -
>  tools/misc/xen-mfndump.c        |  425 
> +++++++++++++++++++++++++++++++++++++++
>  tools/xentrace/xenctx.c         |    9 -
>  17 files changed, 679 insertions(+), 273 deletions(-)
>  create mode 100644 tools/misc/xen-mfndump.c
> 

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel