Re: [Xen-devel] [PATCH v1 02/13] Set VCPU's is_running flag closer to when the VCPU is dispatched

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.09.13 at 17:20, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/xen/common/schedule.c
> +++ b/xen/common/schedule.c
> @@ -1219,8 +1219,14 @@ static void schedule(void)
>       * switch, else lost_records resume will not work properly.
>       */
>  
> -    ASSERT(!next->is_running);
> -    next->is_running = 1;
> +#ifdef CONFIG_X86
> +    if ( is_idle_vcpu(next) )
> +    /* On x86 guests will set is_running right before they start running. */
> +#endif
> +    {
> +        ASSERT(!next->is_running);
> +        next->is_running = 1;
> +    }

I'm not sure the change as a whole is appropriate in the first place
(the patch description is all but assuring that this change doesn't
have unexpected side effects, namely in the individual schedulers),
but this clearly is a no-go: Either do this consistently for ARM too,
or drop the idea.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel