[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH RFC 1/8] xen/arm: Implement ioremap.
On Tue, 2013-09-10 at 16:03 +0100, Julien Grall wrote: > On 09/10/2013 03:18 PM, Ian Campbell wrote: > > Common code uses this, it expects an uncached mapping. > > > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx> > > --- > > xen/arch/arm/mm.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > > index 69c157a..4521c8d 100644 > > --- a/xen/arch/arm/mm.c > > +++ b/xen/arch/arm/mm.c > > @@ -694,6 +694,11 @@ void *ioremap_attr(paddr_t pa, size_t len, unsigned > > int attributes) > > return (__vmap(&pfn, nr, 1, 1, attributes) + offs); > > } > > > > +void *ioremap(paddr_t pa, size_t len) > > +{ > > + return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE); > > +} > > + > > Can you inline ioremap in the header (asm-arm/mm.h)? It's prototyped in xen/include/xen/vmap.h so I don't think so, at least not without introducing subtle header inclusion order traps. It's unlikely to be performance critical so I don't think there is a need to refactor the definition into arch code. > > static int create_xen_table(lpae_t *entry) > > { > > void *p; > > > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |