Re: [Xen-devel] [PATCH V1 03/29] xen/dts: Don't check the number of address and size cells in process_cpu_node

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-09-10 at 11:54 +0100, Julien Grall wrote:
> On 09/10/2013 11:52 AM, Ian Campbell wrote:
> > On Fri, 2013-09-06 at 17:24 +0100, Ian Campbell wrote:
> >> On Wed, 2013-08-28 at 15:47 +0100, Julien Grall wrote:
> >>> CPU nodes are not required to have #address-cells == 1 and #size-cells == 
> >>> 0, so
> >>> don't check for that (see Linux 
> >>> Documentation/devicetree/booting-without-of.txt
> >>> Section III.5.a).
> >>>
> >>> In some OMAP5 device, tree, these 2 properties are not correctly set. 
> >>> Therefore,
> >>> Xen will only able to handle 1 CPU.
> >>>
> >>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> >>
> >> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >>
> >>> CC: andrii.anisov@xxxxxxxxxxxxxxx
> >>> CC: baozich@xxxxxxxxx
> > 
> > I missed Chen's ack from
> > <CCE916EB-FC49-41D4-B672-9BD0D021222C@xxxxxxxxx> when I applied this,
> > please remember to collect them into reposts.
> > 
> > 
> 
> Sorry, as I modified the patch (here the commit message), I though Chen
> have to re-ack it.

It depends, minor stuff like that doesn't invalidate an Ack IMHO. But
you are right, it's a judgement call.

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel