Re: [Xen-devel] [V1 PATCH 3/5] PVH xen tools: libxl changes to create a PVH guest.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-09-05 at 18:23 -0700, Mukesh Rathor wrote:
> On Thu, 5 Sep 2013 11:03:01 +0100
> Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> 
> > On Wed, 2013-09-04 at 18:32 -0700, Mukesh Rathor wrote:
> > > Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> > > ---
> > >  tools/libxl/libxl_create.c   |   12 ++++++++++++
> > >  tools/libxl/libxl_dom.c      |    5 ++++-
> > >  tools/libxl/libxl_internal.h |    1 +
> > >  tools/libxl/libxl_types.idl  |    1 +
> > >  tools/libxl/libxl_x86.c      |    4 +++-
> > >  tools/libxl/xl_cmdimpl.c     |    1 +
> > 
> > Please also modify libxl.h to add a suitable LIBXL_HAVE_xxx #define as
> > described in the big comment about API compatibility.
> 
> Ah, not sure whey LIBXL_API_VERSION can't be used in this case.

They are somewhat orthogonal mechanisms.

>  But, 
> anyways, maybe something like:
> 
> /*
>  * LIBXL_HAVE_PVH_SUPPORT or LIBXL_HAVE_PVH_EXTENSIONS or 
>  *     LIBXL_HAVE_PVH_FEATURE.... 
>  *
>  * If this is defined, the library supports PVH extensions for building a
>  * PV guest to run in HVM container. This is done by adding pvh=1 in the
>  * config file.
>  */
> #define LIBXL_HAVE_PVH_SUPPORT 1

We have a bunch of LIBXL_HAVE_BUILDINFO_FOO, how about
LIBXL_HAVE_CREATEINFO_PVH ? (assuming I'm remembering correctly that
this is where you added the field...)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel