Re: [Xen-devel] [V1 PATCH 2/5] PVH xen tools: libxc changes to build a PVH guest.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-09-05 at 18:12 -0700, Mukesh Rathor wrote:
> On Thu, 5 Sep 2013 11:22:05 +0100
> Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> 
> > On Wed, 2013-09-04 at 18:32 -0700, Mukesh Rathor wrote:
> > > Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> ...
> > >      for ( i = 0; i < XENFEAT_NR_SUBMAPS; i++ )
> > >      {
> > > diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
> > > index 126c0f8..5b2d61d 100644
> > > --- a/tools/libxc/xc_dom_x86.c
> > > +++ b/tools/libxc/xc_dom_x86.c
> > 
> > I don't seem to see anything which would reject PVH on x86_32 at the
> > moment?
> 
> 32bit kernel wouldn't have the elf features so it would be rejected.

A RHEL5 i686 kernel-xen might actual implement all of these features, I
think they did at one point?

> Also, the hypervisor has checks for 32bit guest, and will fail one of
> the hcalls used to build the guest.

Great. Will the error message be comprehensible? It would be a one line
check and error message in vcpu_x86_32 if not.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel