Re: [Xen-devel] [PATCH RFC 2/2] AMD IOMMU: allow command line overrides for broken IVRS tables

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.08.13 at 18:30, Sander Eikelenboom <linux@xxxxxxxxxxxxxx> wrote:
> Tuesday, August 27, 2013, 6:21:02 PM, you wrote:
>> As said, the handling of missing entries should be done by the tail
>> of parse_ivrs_table().
> 
> Ah whoops, it does the setup as well .. of course my printk's in 
> parse_ivhd_device_special() don't show anything then ...
> 
>     /* Each IO-APIC must have been mentioned in the table. */
>     for ( apic = 0; !error && iommu_intremap && apic < nr_ioapics; ++apic )
>     {
>         if ( !nr_ioapic_entries[apic] ||
>              ioapic_sbdf[IO_APIC_ID(apic)].pin_2_idx )
>             continue;
> 
>         if ( !test_bit(IO_APIC_ID(apic), ioapic_cmdline) )
>         {
>             printk(XENLOG_ERR "IVHD Error: no information for IO-APIC %#x\n",
>                    IO_APIC_ID(apic));
>             if ( amd_iommu_perdev_intremap )
>                 return -ENXIO;
>         }
> 
> wouldn't an extra printk mentioning the addition of an entry from cmdline be 
> nice here ?

I'm not sure - I don't really like the trivial echoing of command line
options. Messages should imo be printed only when something has
an effect that one can't immediately imply from specified options
(like is the case when some information from the firmware is being
ignored).

So I'd favor keeping the patch as is, pending the outcome of
Suravee's testing.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel