Re: [Xen-devel] [PATCH RFC 2/2] AMD IOMMU: allow command line overrides for broken IVRS tables

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.08.13 at 18:14, Sander Eikelenboom <linux@xxxxxxxxxxxxxx> wrote:
> Tuesday, August 27, 2013, 5:59:28 PM, you wrote:
> 
>>>>> On 27.08.13 at 16:15, Sander Eikelenboom <linux@xxxxxxxxxxxxxx> wrote:
>>> Where as your implementation seems to only walk the list present from bios 
>>> and override a specific entry when it's mapping them in parse_ivhd_special ?
> 
>> No, the code change to parse_ivrs_table() should be setting up
>> necessary information.
> 
> Well i just checked, and in parse_ivhd_device_special() doing a:
> 
> printk(XENLOG_ERR "is apic 0x6 override parsed ? %d ",  test_bit(0x6, 
> ioapic_cmdline ));
> 
> returns 1 ... so the parsing part seems to be OK.
> 
> but parse_ivhd_device_special() isn't called for ioapic 0x6, because there 
> is no entry for it in the bios provided tables in my case.
> and since that seems to be what is iterated ..

As said, the handling of missing entries should be done by the tail
of parse_ivrs_table().

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel