Re: [Xen-devel] Request fairly urgent reversion of c/s 8a3c4acc9907cfec9aae9f1bc251fbf50af6828e

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-08-27 at 15:06 +0100, Andrew Cooper wrote:
> On 27/08/13 14:16, Jan Beulich wrote:
> >>>> On 27.08.13 at 15:02, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> >> Changeset 8a3c4acc9907cfec9aae9f1bc251fbf50af6828e is my "Clean stacks
> >> in debug builds patch"
> >>
> >> I applied the upstream version to XenServer, and resulted in some
> >> spectacular fails to boot.
> >>
> >> Curiously, the buggy V1 "$(STACK_SIZE >> 8) " works fine on all
> >> hardware, but the apparently correct "$(STACK_SIZE / 8)" causes complete
> >> deadlock on AMD boxes on AP bringup, and causes Intel boxes to only boot
> >> a single pcpu.
> > That original version was broken in the assembly version only iirc,
> > which should not get used in AP bring-up. Hence I'm puzzled.
> 
> Me too.  Literally changing the "$(STACK_SIZE / 8)" to "$(STACK_SIZE >>
> 8)" is sufficient to prevent the problem.

"/ 8" is not the same as ">> 8". ">> 8" is "/ 256". ">> 3" is "/ 8".

(I'm lacking the context to know if this is where you went wrong though)

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel