Re: [Xen-devel] RFC: PVH set vcpu info context in vmcs....

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Wed, Aug 14, 2013 at 10:12 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 14.08.13 at 04:12, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
>> On Tue, 13 Aug 2013 11:56:36 +0100
>> "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>>
>>> >>> On 13.08.13 at 03:45, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
>>> >>> wrote:
>>> > int vmx_pvh_set_vcpu_info(struct vcpu *v, struct vcpu_guest_context
>>> > *ctxtp) {
>>> >     int rc;
>>> >
>>> >     if ( v->vcpu_id == 0 )
>>> >         return 0;
>>>
>>> Bogus/pointless.
>>
>> No, we don't have anything for the boot vcpu. It's totally coming up
>> on the flat address space. For non boot, the vcpu is coming up on the
>> kernel GDT. Recall it's a PV guest (coming up in an HVM container).
>
> No, that's the wrong perspective. You either should never get here
> for vCPU 0, or you should refuse this for all already initialized
> vCPU-s.

+1, FWIW.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel