[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/7] Nested VMX: Allow to ack irq even virtual intr delivery is enabled

>>> On 13.08.13 at 03:10, "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx> wrote:
> Jan Beulich wrote on 2013-08-12:
>>>>> On 11.08.13 at 04:43, "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx> wrote:
>>> Jan Beulich wrote on 2013-08-09:
>>>>>>> On 09.08.13 at 10:49, Yang Zhang <yang.z.zhang@xxxxxxxxx> wrote:
>>>>> From: Yang Zhang <yang.z.zhang@xxxxxxxxx>
>>>>> In some special cases, we want to ack irq regardless of virtual
>>>>> interrupt delivery.
>>>> Again, the whole change is meaningless. I can see reasons to break out
>>>> such preparatory changes when otherwise the resulting patch would be
>>>> huge and hard to review. That doesn't seem to be the case here; it
>>>> rather looks like the splitting was done pretty arbitrarily here.
>>> No, splitting the patch is not only for easy reviewing. It is useful for
>>> "git bisect" and debug purpose. Also, if the change is independent, we also
>>> should to split it into a separate patch.
>>> Here, though the change is minimal, it touches the key interrupt handle
>>> logic. It's better to put it into a single patch.
>> I continue to disagree.
> OK. Then how about to merge it into patch 6?

Yes, that was I was asking for (patch 6 or wherever else the user
of the new code is).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.