Re: [Xen-devel] [PATCH 2/7] Nested VMX: Allow to ack irq even virtual intr delivery is enabled

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.08.13 at 04:43, "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx> wrote:
> Jan Beulich wrote on 2013-08-09:
>>>>> On 09.08.13 at 10:49, Yang Zhang <yang.z.zhang@xxxxxxxxx> wrote:
>>> From: Yang Zhang <yang.z.zhang@xxxxxxxxx>
>>> 
>>> In some special cases, we want to ack irq regardless of virtual
>>> interrupt delivery.
>> 
>> Again, the whole change is meaningless. I can see reasons to break out
>> such preparatory changes when otherwise the resulting patch would be
>> huge and hard to review. That doesn't seem to be the case here; it
>> rather looks like the splitting was done pretty arbitrarily here.
> No, splitting the patch is not only for easy reviewing. It is useful for 
> "git bisect" and debug purpose. Also, if the change is independent, we also 
> should to split it into a separate patch. 
> Here, though the change is minimal, it touches the key interrupt handle 
> logic. It's better to put it into a single patch.

I continue to disagree.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel