Re: [Xen-devel] [PATCH v4 2/2] xen/arm: errata 766422: decode thumb store during data abort

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 08/08/2013 12:09 PM, Ian Campbell wrote:
> On Tue, 2013-08-06 at 19:31 +0100, Julien Grall wrote:
>> +    /*
>> +     * Errata 766422: Thumb store translation fault to Hypervisor may
>> +     * not have correct HSR Rt value.
>> +     */
>> +    if ( cpu_has_errata_766422() && (regs->cpsr & PSR_THUMB) && dabt.write )
>> +    {
>> +        rc = decode_instruction(regs, &info.dabt);
>> +        if ( rc )
>> +            goto bad_data_abort;
> 
> Consider logging here so we know which caller of decode_instruction
> failed?

I will add a printk.

> Either way:
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Ian.
> 


-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel