Re: [Xen-devel] [PATCH v5 3/5] xen/arm: Add the new OMAP UART driver.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-08-08 at 19:58 +0800, Chen Baozi wrote:
> On Aug 8, 2013, at 7:41 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> 
> > On Thu, 2013-08-08 at 18:52 +0800, Chen Baozi wrote:
> > 
> >> +#define omap_read(uart, off)       ioreadl((uart)->regs + 
> >> (off<<REG_SHIFT))
> >> +#define omap_write(uart, off, val) iowritel((uart)->regs + 
> >> (off<<REG_SHIFT), (val))
> > 
> > Other than my comment made on #2 about either using DT or hardcoing
> > REG_SHIFT in this driver I think this patch is good.
> >> diff --git a/xen/include/xen/8250-uart.h b/xen/include/xen/8250-uart.h
> >> index 33daa6d..7498e71 100644
> >> --- a/xen/include/xen/8250-uart.h
> >> +++ b/xen/include/xen/8250-uart.h
> > 
> > To what extent are these changes specific to the TI part?
> > 
> > I guess at least OMAP_* could be in its own header or in the .c file I
> > guess? Not sure what others think about that?
> 
> Hmmm, in Linux, they are in one header (see comments below).

OK, then I guess that's fine by me.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel