Re: [Xen-devel] [XenARM] XEN tools for ARM with Virtualization Extensions

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 12 Jul 2013, Eric Trudeau wrote:
> Here is the separate patch for the clearing of IRQ_GUEST in desc->status 
> during release_irq
> execution.
> 
> From 84cf2265c5eabffa9de538e9b35bca20fe8f55ef Mon Sep 17 00:00:00 2001
> From: Eric Trudeau <etrudeau@xxxxxxxxxxxx>
> Date: Fri, 12 Jul 2013 13:30:48 -0400
> Subject: [PATCH] xen/arm:  Clear the IRQ_GUEST bit in desc->status when
>  releasing an IRQ
> 
> While adding support for guest domU IRQs, I noticed that release_irq did
> not clear the IRQ_GUEST bit in the IRQ's desc->status field.
> This is probably not a big deal since not many situations are likely to arise
> where an IRQ is sometimes host and sometimes guest.
> 
> Signed-off-by: Eric Trudeau <etrudeau@xxxxxxxxxxxx>

We didn't notice this before because nobody calls release_irq at the
moment. In any case:

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>


>  xen/arch/arm/gic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
> index 1487f27..ed15ec3 100644
> --- a/xen/arch/arm/gic.c
> +++ b/xen/arch/arm/gic.c
> @@ -524,6 +524,7 @@ void release_irq(unsigned int irq)
>      action = desc->action;
>      desc->action  = NULL;
>      desc->status |= IRQ_DISABLED;
> +    desc->status &= ~IRQ_GUEST;
> 
>      spin_lock(&gic.lock);
>      desc->handler->shutdown(desc);
> --
> 1.8.1.2
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel