[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/3] libxl: don't write physical-device node for driver domain disks



On Fri, 2013-05-03 at 12:23 +0100, Roger Pau Monne wrote:
> This will be handled by the driver domain itself,

again by udev?

>  since the toolstack
> does not have access to the physical device because it is in a
> different domain.
> 
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxx>
> Cc: George Dunlap <george.dunlap@xxxxxxxxxx>
> ---
>  tools/libxl/libxl.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index 87bda72..bc91fd5 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -2104,7 +2104,8 @@ static void device_disk_add(libxl__egc *egc, uint32_t 
> domid,
>                   * responsible for this since the block device may not
>                   * exist yet.
>                   */
> -                if (!disk->script) {
> +                if (!disk->script &&
> +                    disk->backend_domid == LIBXL_TOOLSTACK_DOMID) {
>                      int major, minor;
>                      libxl__device_physdisk_major_minor(dev, &major, &minor);
>                      flexarray_append_pair(back, "physical-device",



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.