Re: [Xen-devel] [PATCH 2/3] libxl: don't execute hotplug scripts if device is on a driver domain

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-05-03 at 12:23 +0100, Roger Pau Monne wrote:
> Prevent hotplug script execution from libxl if device is on a
> different domain.

The assumption being that the user has enabled udev in the driver
domain?

Is a log message going to be worthwhile?

Does this obsolete run_hotplug_scripts somewhat?

> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxx>
> Cc: George Dunlap <george.dunlap@xxxxxxxxxx>
> ---
>  tools/libxl/libxl_device.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
> index b1fc4ef..bc86648 100644
> --- a/tools/libxl/libxl_device.c
> +++ b/tools/libxl/libxl_device.c
> @@ -903,6 +903,13 @@ static void device_hotplug(libxl__egc *egc, 
> libxl__ao_device *aodev)
>      int hotplug;
>      pid_t pid;
>  
> +    /*
> +     * If device is attached from a driver domain don't try to execute
> +     * hotplug scripts
> +     */
> +    if (aodev->dev->backend_domid != LIBXL_TOOLSTACK_DOMID)
> +        goto out;
> +
>      /* Check if we have to execute hotplug scripts for this device
>       * and return the necessary args/env vars for execution */
>      hotplug = libxl__get_hotplug_script_info(gc, aodev->dev, &args, &env,



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel