Re: [Xen-devel] [PATCH] Introduce an s3 test

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-05-01 at 11:56 +0100, Ian Jackson wrote:
> Ben Guthro writes ("[PATCH] Introduce an s3 test"):
> > From: root <root@bguthro-desktop.(none)>
> > 
> > This test attempts to have an initial pass at introducing a test to catch 
> > regressions in S3.
> > It currently just suspends for N seconds, and checks xl dmesg for a 
> > partiular message printed
> > when S3 is complete.
> 
> Thanks.  Most of this looks plausible.  I have some comments:
> 
> > +# Put the machine to sleep
> > +target_cmd_root($ho, "pm-suspend");
> > +
> > +# Give the machine some time to go to sleep.
> > +sleep (5 + $timeout);
> > +
> > +# check log for resume message
> > +poll_loop(4*$timeout, 2, 's3-confirm-resumed', 
> > +   target_cmd_output($ho,"xl dmesg | grep 'ACPI S' | tail -1 | " .
> > +           "grep -n 'Finishing wakeup from S3 state'"));
> 
> Why does this need a poll loop ?  Surely after the machine comes out
> of suspend it should be up right away ?

Not immediately I expect, but what happens if the ssh fails -- is there
retries at that level which make the poll loop redundant?

Do we need to handle the case where the s3 resume fails such that
subsequent tests can work? i.e. finish up with an explicit
reboot/powercycle?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel