Re: [Xen-devel] [PATCH] Introduce an s3 test

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ben Guthro writes ("[PATCH] Introduce an s3 test"):
> From: root <root@bguthro-desktop.(none)>
> 
> This test attempts to have an initial pass at introducing a test to catch 
> regressions in S3.
> It currently just suspends for N seconds, and checks xl dmesg for a partiular 
> message printed
> when S3 is complete.

Thanks.  Most of this looks plausible.  I have some comments:

> +# Put the machine to sleep
> +target_cmd_root($ho, "pm-suspend");
> +
> +# Give the machine some time to go to sleep.
> +sleep (5 + $timeout);
> +
> +# check log for resume message
> +poll_loop(4*$timeout, 2, 's3-confirm-resumed', 
> +     target_cmd_output($ho,"xl dmesg | grep 'ACPI S' | tail -1 | " .
> +             "grep -n 'Finishing wakeup from S3 state'"));

Why does this need a poll loop ?  Surely after the machine comes out
of suspend it should be up right away ?

> +# TODO:
> +# - Check pcpu state
> +#   - Affinity has been restored
> +#   - C-states are not lost
> +#   - CPU pools are all correct

We don't do any cpu affinity testing at all right now.  Leaving
this as a TODO here is fine.

> +# - Check timer queues are correct
> +#   - vcpu_singleshot_timer on every pcpu

I'm not sure I follow this.  Wouldn't messed up timer queues cause
other trouble in the guest ?

> +# - Check for kernel Oops
> +# - Check for Xen WARN 

These are a good idea but should perhaps be a separate test step.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel