[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 03/13] xen: introduce cpumask_from_bitmap

On 25/04/2013 16:08, "Stefano Stabellini" <stefano.stabellini@xxxxxxxxxxxxx>

> On Thu, 25 Apr 2013, Ian Campbell wrote:
>> On Thu, 2013-04-25 at 15:42 +0100, Ian Campbell wrote:
>>> And it really wants to act on sets of real physical cpus (hence cpumask_t)?
>> Actually, vcpus. Perhaps cpumask_t is the wrong datatype then?
> It seems to me that cpumask_t is a pretty good fit for a vcpu mask.

It's not. It's bounded by NR_CPUS for a start. And it is good documentation
for all uses of cpumasks to be applying to *physical* cpus, otherwise we
will end up even more confused!

I might consider a vcpumask_t of some sort if such an abstraction could be
made to work out nicely (given different domains have different max# of
vcpus). But we managed so far without. ;)

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.