Re: [Xen-devel] [PATCH v3 03/13] xen: introduce cpumask_from_bitmap

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 25/04/2013 15:51, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote:

> On Thu, 2013-04-25 at 15:44 +0100, Ian Campbell wrote:
>> On Thu, 2013-04-25 at 15:42 +0100, Ian Campbell wrote:
>>> And it really wants to act on sets of real physical cpus (hence cpumask_t)?
>> 
>> Actually, vcpus. Perhaps cpumask_t is the wrong datatype then?
> 
> x86 defines for_each_set_bit in terms of find_first_bit and
> find_next_bit (both of which we have on ARM). Seems like we should just
> carry that over?

Yup, seems a shame to duplicate it into asm-arm, but I can live with it. I
can imagine some arch wanting a specialised version of it sometime.

Certainly using cpumask_t for vcpus is very obviously wrong!

 -- Keir

>>> It's emulating a write to a GICD (read: APIC ;-)) register which causes
>>> an SGI (read: IPI) to be sent. The value you write includes an 8 bit
>>> mask indicating the target processors.
>>> 
>>> See "[PATCH v3 04/13] xen/arm: support for guest SGI" in this series.
>>> 
>>> Ian
>> 
>> 
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxx
>> http://lists.xen.org/xen-devel
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel