Re: [Xen-devel] [PATCH 4/4] arm: allocate per-PCPU domheap pagetable pages

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-04-23 at 11:12 +0100, Stefano Stabellini wrote:
> On Tue, 23 Apr 2013, Ian Campbell wrote:
> > > > +    {
> > > > +        pte = mfn_to_xen_entry(virt_to_mfn(domheap+i*LPAE_ENTRIES));
> > > > +        pte.pt.table = 1;
> > > > +        
> > > > write_pte(&first[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SIZE)], 
> > > > pte);
> > > 
> > > Also shouldn't we add an ASSERT to check that DOMHEAP_VIRT_START is
> > > properly aligned?
> > 
> > It would be a BUILD_BUG_ON I think and this would be far from the first
> > place where that would be a problem, are we terribly worried about
> > people changing config.h in ways which would break this? They'd notice
> > pretty quickly..
> 
> No, but fewer assumptions we make, less error prone is the code

I've thrown a patch onto the end of the V2 series which we can see if we
like...

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel