Re: [Xen-devel] [PATCH] drivers/tpm-xen: Change vTPM shared page ABI

[Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>]

On 03/22/2013 08:41 AM, Konrad Rzeszutek Wilk wrote:
> On Thu, Mar 21, 2013 at 04:12:27PM -0400, Daniel De Graaf wrote:
> > This changes the vTPM shared page ABI from a copy of the Xen network
> > interface to a single-page interface that better reflects the expected
> > behavior of a TPM: only a single request packet can be sent at any given
> > time, and every packet sent generates a single response packet.
> What tree is this based on?
This is based off of Matthew Fioravante's latest xen-tpmfront.ko patch:

http://lists.xen.org/archives/html/xen-devel/2012-11/msg01041.html

To build on kernel 3.8, this patch needs __devexit references removed
(as below); I assume this will be addressed when the other issues you
raised when reviewing that patch are fixed.

---

diff --git a/drivers/char/tpm/xen-tpmfront_if.c 
b/drivers/char/tpm/xen-tpmfront_if.c
index ba7fad8..649aee6 100644
--- a/drivers/char/tpm/xen-tpmfront_if.c
+++ b/drivers/char/tpm/xen-tpmfront_if.c
@@ -395,7 +395,7 @@ static int tpmfront_probe(struct xenbus_device *dev,
 }
 
 
-static int __devexit tpmfront_remove(struct xenbus_device *dev)
+static int tpmfront_remove(struct xenbus_device *dev)
 {
        struct tpm_private *tp = tpm_private_from_dev(&dev->dev);
        destroy_tpmring(tp);
@@ -464,7 +464,7 @@ MODULE_ALIAS("xen:vtpm");
 
 static DEFINE_XENBUS_DRIVER(tpmfront, ,
                .probe = tpmfront_probe,
-               .remove =  __devexit_p(tpmfront_remove),
+               .remove = tpmfront_remove,
                .resume = tpmfront_resume,
                .otherend_changed = backend_changed,
                .suspend = tpmfront_suspend,

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel