Re: [Xen-devel] [PATCH 4/4] xen-netback: coalesce slots before copying

[James Harper <james.harper@xxxxxxxxxxxxxxxx>]

> 
>> Actually it turns out GPLPV just stops counting at 20. If I keep
>> counting I can sometimes see over 1000 buffers per GSO packet under
>> Windows using "iperf -
> 
> Do you think it is necessary to increase MAX_SKB_SLOTS_DEFAULT to 21?
> 

Doesn't really matter. Under windows you have to coalesce anyway and the number 
of cases where the skb count is 20 or 21 is very small so there will be 
negligible gain and it will break guests that can't handle more than 19.

Has anyone done the benchmarks on if memcpy to coalesce is better or worse than 
consuming additional ring slots? Probably OT here but I'm talking about packets 
that might have 19 buffers but could fit on a page or two of coalesced.

James

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel