[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/HPET: mask interrupt while changing affinity

>>> On 20.03.13 at 12:55, Sander Eikelenboom <linux@xxxxxxxxxxxxxx> wrote:
> Close but not entirely ;)

Close to not crashing, maybe, but whether this really helps with your
problem is still entirely unclear.

> See attached serial log

Okay, I wasn't even aware of that assertion in _spin_lock_irq().

Keir, do you really think this is necessary? In the prior patch
version, handle_hpet_broadcast() had a flow like this

    if ( next_event != STIME_MAX )

avoiding the saving of the flags in the second lock acquire. Said
assertion makes it impossible to do this.

Sander, in any case, attached a fixed version of the patch (I had
to guess which of the two spin_lock_irq() calls it was, as the log
was incomplete in that the stack trace got dropped, but am pretty
positive that it was the one in handle_hpet_broadcast()).


Attachment: x86-HPET-affinity-masked-deliver.patch
Description: Text document

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.