Re: [Xen-devel] [PATCH 2/8] evtchn: refactor low-level event channel port ops

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 20/03/13 10:21, Jan Beulich wrote:
>>>> On 19.03.13 at 22:00, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
>> --- /dev/null
>> +++ b/xen/common/event_port.c
> 
> Is this really a good name? Wouldn't it be better to have a separate
> file per ABI (e.g. this one being evt_port_2l.c)?

Agreed.  I did this on the Linux side and it's better.

>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -81,6 +81,7 @@ struct evtchn
>>          } pirq;        /* state == ECS_PIRQ */
>>          u16 virq;      /* state == ECS_VIRQ */
>>      } u;
>> +    u32 port;
> 
> The need for this field doesn't become obvious after going
> through the entire patch - if it really needs adding here, the
> description should say why, I would think.

The evtchn_ops calls all take a struct evtchn * as a parameter so we
need this field to get the port.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel