Re: [Xen-devel] [PATCH 1/2] libxl: move check for existence of qemuu device model

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-03-05 at 04:03 +0000, Ian Campbell wrote:
> On Mon, 2013-03-04 at 11:42 +0000, Ian Jackson wrote:
> > Ian Campbell writes ("Re: [Xen-devel] [PATCH 1/2] libxl: move check for 
> > existence of qemuu device model"):
> > > On Fri, 2013-03-01 at 17:41 +0000, Ian Jackson wrote:
> > > > +        if (b_info->device_model_version
> > > > +                == LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
> > > >              const char *dm;
> > > >              int rc;
> > ...
> > > >              rc = access(dm, X_OK);
> > > >              if (rc < 0) {
> > > >                  /* qemu-xen unavailable, use qemu-xen-traditional */
> > ...
> > > After the following change (in 2/2) won't this stat potentially be
> > > checking for the qemu-xen-trad binaries, which makes the error message
> > > somewhat confusing and also makes the fallback unhelpful.
> > 
> > No, because the whole thing is in an if which applies only if we're
> > trying to use ..._QEMU_XEN.
> 
> Oh, right. I combined the tow patches wrongly in my head.

So I think this patch is good as far as it goes and the rest of this
thread is really followup material.
So:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> 
> Don't we also want to check for the presence of the trad binary though?
> 
> > > On a related note we could do with stating the device model even in the
> > > case where the user has specified device_model_version explicitly, to
> > > give better error reporting in that case too.
> > 
> > You mean logging it ?
> 
> Actually I meant "not trying to start the guest regardless and returning
> success", which AIUI is what happens... Logging would be nice too
> though.
> 
> > 
> > Ian.
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel