Re: [Xen-devel] [PATCH 1/2] libxl: move check for existence of qemuu device model

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 1/2] libxl: move check for 
existence of qemuu device model"):
> On Fri, 2013-03-01 at 17:41 +0000, Ian Jackson wrote:
> > +        if (b_info->device_model_version
> > +                == LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
> >              const char *dm;
> >              int rc;
...
> >              rc = access(dm, X_OK);
> >              if (rc < 0) {
> >                  /* qemu-xen unavailable, use qemu-xen-traditional */
...
> After the following change (in 2/2) won't this stat potentially be
> checking for the qemu-xen-trad binaries, which makes the error message
> somewhat confusing and also makes the fallback unhelpful.

No, because the whole thing is in an if which applies only if we're
trying to use ..._QEMU_XEN.

> On a related note we could do with stating the device model even in the
> case where the user has specified device_model_version explicitly, to
> give better error reporting in that case too.

You mean logging it ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel