Re: [Xen-devel] [PATCH v1 05/12] libxl: add new hotplug interface support to hotplug script callers

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[Xen-devel] [PATCH v1 05/12] libxl: add new hotplug 
interface support to hotplug script callers"):
> Add support to call hotplug scripts that use the new hotplug interface
> to the low-level functions in charge of calling hotplug scripts.
> 
> libxl__prepare_ao_device sets the hotplug version to 1, in later
> patches hotplug version will be set to 2 by the caller to use this
> new hotplug calling convention.

I think this needs a comprehensive document describing the new calling
convention.  Since there isn't currently a document describing the old
calling convention I think you may need to do some reverse
engineering.

And then when you do that, there are things about the old calling
convention which are distinctly dodgy and should perhaps be changed.

Is this autoprobing with the "version" argument really the best way to
deal with compatibility ?  I guess we do know that it's reliable.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel