[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v1 04/12] libxl: pack hotplug related variables

Roger Pau Monne writes ("[Xen-devel] [PATCH v1 04/12] libxl: pack hotplug 
related variables"):
> Create a new struct to hold hotplug related variables that are
> scattered in libxl__ao_device. We will later expand the number of
> hotplug related variables, so it's best to have them packed
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>

I think you should avoid the word "packed" which normally makes people
think of removing structure memory layout padding.  "grouped"
perhaps ?

Apart from that, which I think is just a comment about the commit

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.