Re: [Xen-devel] [PATCH v1 04/12] libxl: pack hotplug related variables

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[Xen-devel] [PATCH v1 04/12] libxl: pack hotplug 
related variables"):
> Create a new struct to hold hotplug related variables that are
> scattered in libxl__ao_device. We will later expand the number of
> hotplug related variables, so it's best to have them packed
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>

I think you should avoid the word "packed" which normally makes people
think of removing structure memory layout padding.  "grouped"
perhaps ?

Apart from that, which I think is just a comment about the commit
message:

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel