Re: [Xen-devel] [PATCH 1/2] x86/Intel: Provide comments for which model is what.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Fri, Mar 01, 2013 at 02:45:08PM +0000, Tim Deegan wrote:
> At 09:31 -0500 on 01 Mar (1362130307), Konrad Rzeszutek Wilk wrote:
> > +        case 15: /* original 65 nm celeron/pentium/core2/xeon, 
> > "Merom"/"Conroe" */
> > +        case 23: /* current 45 nm celeron/core2/xeon "Penryn"/"Wolfdale" */
> 
> No opinion about the patch in general, but it might be better not to say
> "current" here, at least without attaching a date.

OK. How about this:

commit 7de84d0668df18977ebc9c299d6562676e76dbd5
Author: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date:   Fri Mar 1 09:21:35 2013 -0500

    x86/Intel: Provide comments for which model is what.
    
    [v1: Tim suggested to remove 'current' from the comments]
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

diff --git a/xen/arch/x86/hvm/vmx/vpmu_core2.c 
b/xen/arch/x86/hvm/vmx/vpmu_core2.c
index 2cef2d6..5d22a70 100644
--- a/xen/arch/x86/hvm/vmx/vpmu_core2.c
+++ b/xen/arch/x86/hvm/vmx/vpmu_core2.c
@@ -738,16 +738,16 @@ int vmx_vpmu_initialise(struct vcpu *v, unsigned int 
vpmu_flags)
     {
         switch ( cpu_model )
         {
-        case 15:
-        case 23:
-        case 26:
-        case 29:
-        case 42:
-        case 45:
-        case 46:
-        case 47:
-        case 58:
-        case 62:
+        case 15: /* original 65 nm celeron/pentium/core2/xeon, 
"Merom"/"Conroe" */
+        case 23: /* 45 nm celeron/core2/xeon "Penryn"/"Wolfdale" */
+        case 26: /* 45 nm nehalem, "Bloomfield" */
+        case 29: /* six-core 45 nm xeon "Dunnington" */
+        case 42: /* SandyBridge */
+        case 45: /* SandyBridge, "Romely-EP" */
+        case 46: /* 45 nm nehalem-ex, "Beckton" */
+        case 47: /* 32 nm Xeon E7 */
+        case 58: /* IvyBridge */
+        case 62: /* IvyBridge EP */
             ret = core2_vpmu_initialise(v, vpmu_flags);
             if ( !ret )
                 vpmu->arch_vpmu_ops = &core2_vpmu_ops;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel