Re: [Xen-devel] [PATCH 1/2] x86/Intel: Provide comments for which model is what.

[Tim Deegan <tim@xxxxxxx>]

At 09:31 -0500 on 01 Mar (1362130307), Konrad Rzeszutek Wilk wrote:
> +        case 15: /* original 65 nm celeron/pentium/core2/xeon, 
> "Merom"/"Conroe" */
> +        case 23: /* current 45 nm celeron/core2/xeon "Penryn"/"Wolfdale" */

No opinion about the patch in general, but it might be better not to say
"current" here, at least without attaching a date.

Tim.

> +        case 26: /* 45 nm nehalem, "Bloomfield" */
> +        case 29: /* six-core 45 nm xeon "Dunnington" */
> +        case 42: /* SandyBridge */
> +        case 45: /* SandyBridge, "Romely-EP" */
> +        case 46: /* 45 nm nehalem-ex, "Beckton" */
> +        case 47: /* 32 nm Xeon E7 */
> +        case 58: /* IvyBridge */
> +        case 62: /* IvyBridge EP */
>              ret = core2_vpmu_initialise(v, vpmu_flags);
>              if ( !ret )
>                  vpmu->arch_vpmu_ops = &core2_vpmu_ops;
> -- 
> 1.8.0.2
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel