Re: [Xen-devel] [PATCHv4 4/5] exec, memory: Call to xen_modified_memory.

[Alex Bligh <alex@xxxxxxxxxxx>]

Stefano,

--On 20 February 2013 12:30:45 +0000 Stefano Stabellini 
<stefano.stabellini@xxxxxxxxxxxxx> wrote:
> Also add a call to xen_modified_memory from
> cpu_physical_memory_set_dirty, if I am not mistaken that should solve
> the problem with the dirty vram.
I think I now recall why I did not do this.

Firstly, cpu_physical_memory_set_dirty is inline, and I'd have to check
(presumably) xen_enabled() then call a non-inline function. This seemed
a bit much to satisfy only the needs of the VRAM check as (as far as I
could tell - I may well be wrong) xen_modifed_memory was being called
appropriately by all the other callers anyway.

Secondly, if I do need to modify this one, it seemed odd that I'd need
not need to modify cpu_physical_set_dirty_flags.

It seemed cleaner just to fix up the VRAM stuff.

What do you think? I'll send another patch series with everything else
in.

--
Alex Bligh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel