Re: [Xen-devel] [PATCHv4 4/5] exec, memory: Call to xen_modified_memory.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 19 Feb 2013, Alex Bligh wrote:
> --On 19 February 2013 18:03:04 +0000 Stefano Stabellini 
> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> 
> > e226939de5814527a21396903b08c3d0ed989558 adds two calls to
> > xen_modified_memory, one in cpu_physical_memory_set_dirty_range, the
> > other in invalidate_and_set_dirty.
> >
> > Where does this one come from?
> >
> > If something is missing you need to backport that patch too, rather than
> > trying to adapt this patch.
> > In this case I believe you need to backport
> > 1720aeee72888f80b974c33b6eb39922a0bea992.
> 
> Again, I was trying to make the fewest changes possible, being aware I
> have little understanding of the code. Some assistance would be appreciated
> here particularly as the substitute patch you mention would appear to have
> have wider implications.

OK. Keep the patch as you wrote it and add a comment in the description
saying why you needed to make the additional changes that are not part
of e226939de5814527a21396903b08c3d0ed989558.

Also add a call to xen_modified_memory from
cpu_physical_memory_set_dirty, if I am not mistaken that should solve
the problem with the dirty vram.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel